Re: NOHZ: local_softirq_pending 08

[Dave Jones]

On Fri, Jun 08, 2012 at 06:33:09PM -0400, Marc Dionne wrote:
 > On Fri, Jun 8, 2012 at 5:53 PM, Francois Romieu <romieu@xxxxxxxxxxxxx> wrote:
 > > index 4a05b68..d452441 100644
 > > --- a/drivers/net/ethernet/realtek/r8169.c
 > > +++ b/drivers/net/ethernet/realtek/r8169.c
 > > @@ -5934,11 +5934,7 @@ static void rtl_slow_event_work(struct rtl8169_private *tp)
 > >        if (status & LinkChg)
 > >                __rtl8169_check_link_status(dev, tp, tp->mmio_addr, true);
 > >
 > > -       napi_disable(&tp->napi);
 > > -       rtl_irq_disable(tp);
 > > -
 > > -       napi_enable(&tp->napi);
 > > -       napi_schedule(&tp->napi);
 > > +       rtl_irq_enable_all(tp);
 > >  }
 > >
 > >  static void rtl_task(struct work_struct *work)
 > 
 > That works for me - no warnings after several reboots and bringing the
 > interface up/down many times.

Yep, looks good to me too. Thanks Francois

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/