Re: [PATCH 4/7] remoteproc: Assign boot_addr in a separate function

[Ohad Ben-Cohen]

On Wed, Jun 6, 2012 at 4:38 PM,  <sjur.brandeland@xxxxxxxxxxxxxx> wrote:
> +/**
> + * rproc_set_boot_addr() - Set rproc's boot address.
> + * @rproc: remote processor which needs boot address set.
> + * @fw: the  the ELF firmware image

typo: s/the the/the/

> -       rproc->bootaddr = ehdr->e_entry;
> +       rproc_set_boot_addr(rproc, fw);

We might want to do this a little bit differently, something like:

rproc->bootaddr = rproc_get_boot_addr(rproc, fw);

This way the binary-format-specific handler really only retrieves the
boot address, without manipulating the framework's rproc structure.

If such handler doesn't exist, a default zero can be returned.

Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/