Re: [PATCH] driver core: fix shutdown races with probe/remove(v1)

From: Ming Lei
Date: Sun Jun 10 2012 - 10:06:57 EST


On Fri, Jun 8, 2012 at 9:40 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
>
> Would you prefer to use device_trylock in a loop?  I guess this comes

Yes, looks trylock in loop is safer than locking simply, and another
advantage is that the buggy device or driver can be logged.

So will do the v2 using trylock.

> down to which you prefer: a hang during shutdown, or a crash.  :-)

Considered that the device or driver can be logged, either hang or
crash will be fixed later by someone, :-)

Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/