Re: [PATCH 24/24] TTY: use tty_port_register_device

[Jiri Slaby]

On 06/04/2012 07:00 PM, Alan Cox wrote:
>> In this patch we modify most of the drivers to do the latter. When the
>> drivers use tty_register_device and we have tty_port already, we
>> switch to tty_port_register_device. So we have the tty_struct =>
>> tty_port link for free for those.
> 
> Nice solution

Seems so on the first glance... But it is racy. There is a window since
tty_register_driver to tty_(port_)register_device where a node may be
opened already, but tty_port won't be set up yet.

The fix is to move cdev_add from tty_register_driver to
tty_register_device, which makes sense anyway. Any objections?

For the time being, Greg, please ignore 24/24 from these series (I see
you haven't applied any of the patches yet.)

thanks,
-- 
js
suse labs


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/