Re: [PATCH v2 02/10] mm: frontswap: trivial coding convention issues

From: Sasha Levin
Date: Fri Jun 08 2012 - 16:36:35 EST


On Fri, Jun 8, 2012 at 10:16 PM, Pekka Enberg <penberg@xxxxxxxxxx> wrote:
> On Fri, Jun 8, 2012 at 10:15 PM, Sasha Levin <levinsasha928@xxxxxxxxx> wrote:
>> Signed-off-by: Sasha Levin <levinsasha928@xxxxxxxxx>
>> ---
>>  mm/frontswap.c |    5 +++--
>>  1 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/mm/frontswap.c b/mm/frontswap.c
>> index 557e8af4..b619d29 100644
>> --- a/mm/frontswap.c
>> +++ b/mm/frontswap.c
>> @@ -150,6 +150,7 @@ int __frontswap_store(struct page *page)
>>                inc_frontswap_failed_stores();
>>        } else
>>                inc_frontswap_failed_stores();
>> +       }
>
> This looks wrong. Did you compile it?

gah... yes, I've had an error in the merge resolution, but since that
code is completely changed in next couple of patches I didn't notice
it when building the final version. I really should build after each
merge failure...

Konrad, would it be ok if I send just a new version of this patch (if
everything else is fine)?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/