Re: [PATCH 1/7] drivers/ide/ide-cs.c: adjust suspicious bitoperation

From: Julia Lawall
Date: Fri Jun 08 2012 - 01:12:30 EST


On Thu, 7 Jun 2012, David Miller wrote:

From: Julia Lawall <Julia.Lawall@xxxxxxx>
Date: Wed, 6 Jun 2012 23:41:35 +0200

- if (!(pdev->resource[0]->flags & IO_DATA_PATH_WIDTH_8)) {
+ if ((p1dev->resource[0]->flags & IO_DATA_PATH_WIDTH)

I'm really surprised someone as thorough as yourself did not
compile test this.

Sorry, I changed the patch at the last minute, and it was indeed not a good idea not to have compiled again. I will send another version, in case it is useful.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/