Re: [patch 12/12] mm: correctly synchronize rss-counters at exit/exec

From: Linus Torvalds
Date: Thu Jun 07 2012 - 21:20:15 EST


No, this is apparently that same "almost there" patch from Oleg. I
guarantee that it's wrong.

Linus

---

[ This part, to be exact: ]

On Thu, Jun 7, 2012 at 6:16 PM, Hugh Dickins <hughd@xxxxxxxxxx> wrote:
> --- a/kernel/tsacct.c
> +++ b/kernel/tsacct.c
> @@ -91,6 +91,7 @@ void xacct_add_tsk(struct taskstats *stats, struct task_struct *p)
>        stats->virtmem = p->acct_vm_mem1 * PAGE_SIZE / MB;
>        mm = get_task_mm(p);
>        if (mm) {
> +               sync_mm_rss(mm);
>                /* adjust to KB unit */
>                stats->hiwater_rss   = get_mm_hiwater_rss(mm) * PAGE_SIZE / KB;
>                stats->hiwater_vm    = get_mm_hiwater_vm(mm)  * PAGE_SIZE / KB;
> --
> 1.5.5.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/