Re: [PATCH] e1000e: disable rxhash when try to enable jumbo framealso rxhash and rxcsum have enabled

[David Miller]

From: Joe Jin <joe.jin@xxxxxxxxxx>
Date: Fri, 08 Jun 2012 09:06:40 +0800

> Upstream commit 70495a5 check if both rxhash and rxcsum enabled when enabling
> jumbo frames and disallowed all of them enabled at the same time.
> 
> Since jumbo frame widely be used in real world, so when try to enable jumbo
> frames but rxhash and rxcsum have enabled, change the default behavior to
> disable receive hashing.
> 
> Signed-off-by: Joe Jin <joe.jin@xxxxxxxxxx>
> Signed-off-by: Guru Anbalagane <guru.anbalagane@xxxxxxxxxx>
> Acked-by: Adnan Misherfi <adnan.misherfi@xxxxxxxxxx>

If I were the Intel developers I would not apply this patch, it sets
a very bad precedence.

The tool tells you that the combination you're attempting to use is
invalid, and the kernel log message tells you exactly why.

The driver should never automatically change configuration settings
not actually requested by the user.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/