Re: [PATCH] e1000: save skb counts in TX to avoid cache misses

From: Jeff Kirsher
Date: Thu Jun 07 2012 - 18:02:59 EST


On 06/07/2012 02:43 PM, David Miller wrote:
> From: Jeff Kirsher <tarbal@xxxxxxxxx>
> Date: Thu, 07 Jun 2012 14:38:17 -0700
>
>> Thanks! I have applied the patch to my queue
> Why?
>
> My impression is that this is a patch already in the tree, and it's
> being submitted for -stable but such minor performance hacks are
> absolutely not appropriate for -stable submission.
I did not catch that Roman was trying to get this into stable because
there was no mention of what stable kernels this was applicable back to
(and the fact that it was a performance).

I thought he had found an issue with the previous commits and was
suggesting a fix to the previous patches.

Since he is trying to get this into -stable, disregard my statement
about adding it to my tree.

Attachment: signature.asc
Description: OpenPGP digital signature