Re: [patch] irq: use config_enabled(SMP) checks to cleanupirq_set_affinity() for UP

From: Suresh Siddha
Date: Thu Jun 07 2012 - 16:31:48 EST


On Wed, 2012-06-06 at 18:36 -0700, Yinghai Lu wrote:
> On Wed, Jun 6, 2012 at 4:29 PM, Suresh Siddha <suresh.b.siddha@xxxxxxxxx> wrote:
> > On Ingo's request, re-basing the previous version
> > (http://marc.info/?l=linux-kernel&m=133667389223282) to the latest -tip
> > tree. Thanks.
> > ---
> > From: Suresh Siddha <suresh.b.siddha@xxxxxxxxx>
> > Subject: irq: use config_enabled(CONFIG_SMP) checks to cleanup irq_set_affinity() for UP
> >
> > Use config_enabled(CONFIG_SMP) checks for cleaning up the ifdef CONFIG_SMP
> > around irq_set_affinity routines in io_apic and irq_remapping subsystems.
>
> can you just use
> if (nr_cpu_ids > 1)
> checking instead
> if config_enabled(CONFIG_SMP)

Idea is to not have any extra runtime checks if CONFIG_SMP is enabled
and which is when all the smp affinity routines are used/invoked.

thanks,
suresh


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/