Re: [PATCH] Disable Bus Master on PCI device shutdown

From: Andi Kleen
Date: Thu Jun 07 2012 - 13:07:29 EST


Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> writes:

>> This protects against the case where a piece of hardware is continuing
>> to DMA even after the driver shutdown method has been called? I'm not
>
> It doesn't. We also have hardware which craps itself if you clear the bus
> mastering bit and we have platforms where the BIOS gets most upset if you
> do that on suspend paths. There are also lots of devices that simply
> ignore the bus mastering bit !

But it also makes my system do kexec successfully for the first time.

Maybe can make it an option.

n-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/