Re: [PATCH] change lock model in aio_put_req

[Jeff Moyer]

mihailov ivan <mihailov.iaa@xxxxxxxxx> writes:

> Why used spin_lock/unlock_irq instead of
> spin_lock_irqsave/spin_unlock_irqrestore?

Because the function is never called from interrupt context.

> __aio_put_req it's interrupt safe call but why aio_put_req not?

__aio_put_req is called with the ctx lock already taken.  This (the __
routine being called with the lock held) is a fairly common convention
in the kernel.

Nack.  Your patch doesn't fix anything.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/