Re: [PATCH 1/5] perf, x86: Don't assume the alternative cycles encoding is architectural

From: Andi Kleen
Date: Wed Jun 06 2012 - 12:08:50 EST


On Wed, Jun 06, 2012 at 04:53:05PM +0200, Peter Zijlstra wrote:
>
> > So your patch would fix the problem iff you only fill in the pebs_aliases
> > in the model number switch for known Core model numbers.
>
> + if (event->attr.precise_ip && x86_pmu.pebs_aliases)
> + x86_pmu.pebs_aliases(event);
>
> Never happens, and we're happy again.

How about newer unknown Intel CPUs with arch_perfmon >= 3? Those would get
intel_pmu, correct? There's no guarantee that they support the trick.

-Andi


--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/