Re: [Xen-devel] [PATCH] x86/amd: fix crash as Xen Dom0 on AMDTrinity systems

From: Ingo Molnar
Date: Wed Jun 06 2012 - 05:27:15 EST



* H. Peter Anvin <hpa@xxxxxxxxx> wrote:

> On 05/30/2012 03:33 PM, Konrad Rzeszutek Wilk wrote:
> > diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
> > index 75f33b2..e74df95 100644
> > --- a/arch/x86/xen/enlighten.c
> > +++ b/arch/x86/xen/enlighten.c
> > @@ -1116,7 +1116,10 @@ static const struct pv_cpu_ops xen_cpu_ops __initconst = {
> > .wbinvd = native_wbinvd,
> >
> > .read_msr = native_read_msr_safe,
> > + .rdmsr_regs = native_rdmsr_safe_regs,
> > .write_msr = xen_write_msr_safe,
> > + .wrmsr_regs = native_wrmsr_safe_regs,
> > +
> > .read_tsc = native_read_tsc,
> > .read_pmc = native_read_pmc,
> >
>
> Okay, tell me again:
>
> why do we have these hooks again? Can we please weed out
> paravirt methods that have no users?

ping?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/