Re: [PATCH 13/24] TTY: um/line, use tty from tty_port

[Jiri Slaby]

On 06/04/2012 02:01 PM, Richard Weinberger wrote:
> I have two questions: 1. Are these patches also usable on 3.4 and
> 3.3 or do they depend on 3.5's TTY changes?

Hi, I don't think they depend on any changes.

> 2. Why didn't you use tty_port_open()/close()/etc. as Alan
> suggested my in [1]?

This was not intended to fix anything particular. If it does, it is a
pure coincidence... These patches are a minimalistic subset to ensure
every driver has its own tty_port for each tty. We will need this
pairing later.

So the switch of the driver to the new tty port API, as suggested by
Alan, is still needed. I might do that later if I learn how to make
UML work. (The conversion is by definition invasive and needs runtime
testing.)

> [1]
> http://lkml.indiana.edu/hypermail/linux/kernel/1201.3/01705.html

thanks,
-- 
js
suse labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/