Re: Is this code right in zram?

From: Jerome Marchand
Date: Mon Jun 04 2012 - 08:47:17 EST


On 06/04/2012 02:33 PM, Joe Perches wrote:
> On Mon, 2012-06-04 at 14:08 +0200, Jerome Marchand wrote:
>> It probably doesn't matter much.
>
> Likely true.
>
>> Apparently kcalloc() never got a lot
>> of success and kzalloc(sizeof(foo) * num_foos) type of allocation are
>> more popular.
>
> Likely false, especially in new code.
>
> If you did greps, perhaps you are including the
> k.alloc(sizeof(*foo), GFP)
> forms in your uses multiply counts.

No. Actually I greped it and look quickly at which proportion of those
kzalloc() looked like the above. I have to admit that my sample was
small and certainly not evenly distributed around the source tree.

Jerome

>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/