Re: [PATCH 1/2] 8139cp: set ring address before enabling receiver

From: David Miller
Date: Fri Jun 01 2012 - 14:23:11 EST


From: Jason Wang <jasowang@xxxxxxxxxx>
Date: Fri, 01 Jun 2012 12:19:39 +0800

> Currently, we enable the receiver before setting the ring address which could
> lead the card DMA into unexpected areas. Solving this by set the ring address
> before enabling the receiver.
>
> btw. I find and test this in qemu as I didn't have a 8139cp card in hand. please
> review it carefully.
>
> Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>

I hate bugs like this, the other common issue is enabling interrupts
before the chip is fully programmed.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/