Re: [PATCH v2 1/3] leds: add oneshot blink functions

From: Shuah Khan
Date: Fri Jun 01 2012 - 11:39:39 EST



>
> There should be no compatibity issues with current timer-trigger calls,
> can you be more specific?

My initial thought was that maybe you could create new namespace for
this trigger instead of using delay_on and delay_off. However, after
looking closely at the patch set you are proposing, since you are using
delay_on and delay_off in led_cdev, I think you are ok.


Please make sure there is no regression in the ledtrig-timer use-cases,
with the changes made to led-class and led-core.

-- Shuah


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/