Re: [PATCH 1/3] uprobes/core: Remove redundantlock_page/unlock_page

[Srikar Dronamraju]

* Peter Zijlstra <peterz@xxxxxxxxxxxxx> [2012-05-31 18:56:12]:

> On Thu, 2012-05-31 at 20:37 +0530, Srikar Dronamraju wrote:
> > * Peter Zijlstra <peterz@xxxxxxxxxxxxx> [2012-05-31 13:58:38]:
> > 
> > > On Thu, 2012-05-31 at 17:16 +0530, Srikar Dronamraju wrote:
> > > > From: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>
> > > > 
> > > > No need to lock the page when copying the opcode in read_opcode().
> > > 
> > > It would be good if the changelog said _why_ this is so :-)
> > 
> > In read_opcode(), we have the reference for the page and we only are reading
> > from the the page. i.e we are neither modifying the page contents, not
> > the page attributes. 
> 
> Fair enough, so put that in the changelog. The changelog should explain
> things, not raise questions.
> 

Okay, will add this info to the Changelog and resend the patch.

-- 
Thanks and Regards
Srikar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/