Re: [PATCH 1/3] uprobes: install_breakpoint() should fail ifis_swbp_insn() == T

[Srikar Dronamraju]

* Peter Zijlstra <peterz@xxxxxxxxxxxxx> [2012-05-31 14:15:18]:

> On Wed, 2012-05-30 at 19:49 +0200, Peter Zijlstra wrote:
> > 
> > Oh, indeed. I overlooked copy_insn() is taking the page from the
> > page-cache instead of the page-tables and will thus get the original.
> > 
> 
> Related to this, what happens when we try to install a probe on a page
> that's already been COWed by a ptrace user?
> 
> Say gdb did a code modification at or near the intended probe site.
> 

If the page is already COWED because of an existing code modification
near the intended probe site, we are replacing it with another page
keeping the previous modification as is.

ptrace and uprobes tracing the same instruction wont work cleanly for
now.

-- 
thanks and regards
Srikar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/