Re: [PATCH 2/2] pidns: find_new_reaper() can no longer switch toinit_pid_ns.child_reaper

[Pavel Emelyanov]

On 05/30/2012 10:15 PM, Oleg Nesterov wrote:
> find_new_reaper() changes pid_ns->child_reaper, see add0d4df
> "pid_ns: zap_pid_ns_processes: fix the ->child_reaper changing".
> 
> The original reason has gone away after the previous patch,
> ->children list must be empty after zap_pid_ns_processes().
> 
> However now we can not switch to init_pid_ns.child_reaper.
> __unhash_process() relies on the "->child_reaper == parent"
> check, but this check does not work if the last exiting task
> is also the child reaper.
> 
> As Eric sugested, we can change __unhash_process() to use the
> parent's pid_ns and remove this code.
> 
> Also, with this change we can move detach_pid(PIDTYPE_PID) back,
> where it was before the previous fix.
> 
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
> Acked-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>

Acked-by: Pavel Emelyanov <xemul@xxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/