Re: [PATCHv5 5/5] kvm: host side for eoi optimization

[Gleb Natapov]

On Thu, May 31, 2012 at 01:11:11PM +0300, Michael S. Tsirkin wrote:
> On Thu, May 31, 2012 at 12:57:10PM +0300, Gleb Natapov wrote:
> > > @@ -1345,17 +1437,40 @@ void kvm_lapic_sync_from_vapic(struct kvm_vcpu *vcpu)
> > >  	apic_set_tpr(vcpu->arch.apic, data & 0xff);
> > >  }
> > >  
> > > +/*
> > > + * apic_sync_pv_eoi_to_guest - called before vmentry
> > > + *
> > > + * Detect whether it's safe to enable PV EOI and
> > > + * if yes do so.
> > > + */
> > > +static void apic_sync_pv_eoi_to_guest(struct kvm_vcpu *vcpu,
> > > +					struct kvm_lapic *apic)
> > > +{
> > > +	if (!pv_eoi_enabled(vcpu) ||
> > > +	    /* IRR set or many bits in ISR: could be nested. */
> > > +	    unlikely(apic->irr_pending) ||
> > > +	    unlikely(apic->isr_count != 1) ||
> > Remind me why pv_eoi should not be set if there is more than one isr?
> 
> There's a comment below: it might be safe but
> we do not bother: no easy way to know which interrupt
> has higher priority.
Last injected interrupt has highest priority.

> 
> In my testing more than one bit almost never happens in practice so not
> worth optimizing for.
> 
> 
> > 
> > > +	    /* Cache not set: safe but we don't bother. */
> > > +	    unlikely(apic->isr_cache == -1) ||
> > > +	    /* Need EOI to update ioapic. */
> > > +	    unlikely(kvm_ioapic_handles_vector(vcpu->kvm, apic->isr_cache)))
> > > +		return;
> > > +
> > > +	pv_eoi_set_pending(apic->vcpu);
> > > +}
> > > +
> > apic_sync_pv_eoi_to_guest() is not paired with
> > apic_sync_pv_eoi_from_guest() if event injection is canceled.
> > You can enter guest with stale pv_eoi bit.
> 
> Never. The pv_eoi bit is cleared on each exit.
There will be no exit since there will be no entry. Search for
"goto out" after kvm_lapic_sync_to_vapic().

> It will stay cleared unless we set it here.
> I will add a comment.

--
			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/