Re: [RFC PATCH] clk: add extension API

[Peter De Schrijver]

> > > on Tegra:
> > > 
> > > device_reset(dev)
> > > 	-> dev_pm_domain->reset()
> > > 		-> tegra_periph_reset()
> > > 
> > 
> > These methods are also needed internally by the powergating code.
> 
> so ? Just call them when you need...
> 

the powergating code calls assert and deassert indepedently
ie:

tegra_periph_reset_assert()

do stuff

tegra_periph_reset_assert()

> > > on OMAP:
> > > 
> > > device_reset(dev)
> > > 	-> dev_pm_domain->reset()
> > > 		-> omap_hwmod_reset()
> > > 
> > > 
> > > btw:
> > > 
> > > tegra_periph_reset(....)
> > > {
> > > 	tegra_periph_reset_assert(...);
> > > 	udelay(2);
> > > 	tegra_periph_reset_deassert(...);
> > > }
> > 
> > which uses the clockframework currently.
> 
> no problems there. The point is that you already know which clock feed
> into which device, so if you have a device-based API for device
> soft-reset, you can figure out which exact clock to toggle, right ?

you have the struct clk, you could dive into that and grab clk_hw and call
some function directly. But sounds quite horrible to me.

Cheers,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/