Re: [RFC PATCH] clk: add extension API
From: Saravana Kannan
Date: Wed May 30 2012 - 23:30:03 EST
On 05/30/2012 12:40 PM, Mike Turquette wrote:
On 20120530-01:52, Stephen Boyd wrote:
On 5/29/2012 2:58 AM, Peter De Schrijver wrote:
Add an extension API for clocks. This allows clocktypes to provide extensions
for features which are uncommon and cannot be easily mapped onto normal clock
framework concecpts. eg: resetting blocks, configuring clock phase etc.
This seems rather generic. Why not add more specific APIs/concepts like
clk_reset(), clk_set_phase(), etc.? If they don't map, maybe we should
make them map.
I also wonder if exposing some of these knobs should be done in the
basic clock types. Meaning that instead of having additional calls in
the clk.h API those calls could be exposed by the basic clock types that
map to the actions.
The question that needs to be answered is this: do generic drivers need
access to these additional functions (clk.h) or just the platform code
which implements some of the clock logic (basic clock types&
platform-speciic clock types).
One of the main reason for the common clock framework is so that each
platform doesn't have it's own extension and have mostly similar code
repeat all over the place. So, having clock APIs outside of clk.h
doesn't make sense when we look at the direction we want the code base
to proceed in.
-Saravana
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/