Re: [PATCH] crypto: serpent - add x86_64/avx assemblerimplementation

[Johannes Goetzfried]

On Wed, May 30, 2012 at 06:26:45PM +0200, Andi Kleen wrote:
> > I tried to be consistent with the existing ciphers in arch/x86/crypto.
> > In serpent_sse2_glue.c and sha1_ssse3_glue.c it is done exactly that way, so if
> > it will be decided to remove the printk in this patch it probably should also
> > be removed in the other modules.
> 
> 
> They are wrong and need to be fixed.
> 
> Drivers can be loaded for all kinds of reasons, but they are not supposed
> to spam your kernel log when they do nothing.
> 
> In fact I fixed all the existing ones with the cpuid changes, unfortunately
> somehow snuck in wrong code :-(

Hm, ok, removing the printk stuff is no big deal. I would fix this together
with the cpuid probing, when I'm sure that this is the preferred "new" way :-)

- Johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/