Re: [Xen-devel] [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinitysystems

From: H. Peter Anvin
Date: Wed May 30 2012 - 13:33:05 EST


On 05/30/2012 10:17 AM, Konrad Rzeszutek Wilk wrote:
>> Yes, the following patch also fixed the crash for us:
>>
>> Implement rdmsr_regs and wrmsr_regs for Xen pvops.
>
> That needs more data. Such as the reason for it, the crash
> tombstone, and an analysis of the bug.
>
> But at this point I am not sure what we are going to do.
>
> I think Peter leans towards ripping the .rdmsr_regs/wdmsr_regs
> function out altogether (so altering the amd_rdmsr... to use the
> .rdmsr/.wrdmsr). At which point I think this would all work
> just fine?
>

No, you can't just do that. Rip them out as in trap and emulate.

-hpa


--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/