Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure

From: Glauber Costa
Date: Wed May 30 2012 - 10:33:36 EST


On 05/30/2012 05:37 PM, Frederic Weisbecker wrote:
Right. __mem_cgroup_get_kmem_cache() fetches the memcg of the owner
and calls memcg_create_cache_enqueue() which does css_tryget(&memcg->css).
After this tryget I think you're fine. And in-between you're safe against
css_set removal due to rcu_read_lock().

I'm less clear with __mem_cgroup_new_kmem_page() though...

That one does not get memcg->css but it does call mem_cgroup_get(), that does prevent against the memcg structure being freed, which I believe to be good enough.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/