Re: [PATCH 08/22] regulator: Change ab8500 match names to reflectDevice Tree

From: Mark Brown
Date: Wed May 30 2012 - 06:03:48 EST


On Wed, May 30, 2012 at 02:58:44PM +0800, Linus Walleij wrote:
> On Wed, May 30, 2012 at 12:47 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:

> > +       { .name = "ab8500_ldo_ana",     .driver_data = (void *) AB8500_LDO_ANA, },

> So why is the device tree going to use these lowercase names etc?
> I guess there is a rationale...

If we are changing the names then not including the ab8500 bit would
seem more idiomatic - we've already worked out which chip this is by the
time we're looking here.

> Anyway: the name is used in more parts of the file, so please change
> it everywhere if you change it.

It's only used for a few debug prints AFAICT?

Attachment: signature.asc
Description: Digital signature