Re: [PATCH] crypto: serpent - add x86_64/avx assemblerimplementation

[Jussi Kivilinna]

Quoting Andi Kleen <andi@xxxxxxxxxxxxxx>:

> The driver needs CPUID annotations now (since 3.3), so that it can be
> autoloaded.  Something like:

Is it really good idea to autoload crypto modules? Currently loading  
different cipher implementations is handled via module-aliases and  
cipher priorities. With autoloading by CPUID, crypto-modules would be  
loaded and be mostly unused. For example, serpent-sse2 would be  
autoloaded on all x86-64 kernels (well, on those that have it compiled  
as module => probably most of distros).

IMHO these should be loaded only when needed, as is done with generic  
i586/x86-64 assembler cipher implementations.

-Jussi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/