Re: [PATCH 2/2] block: Convert BDI proportion calculations toflexible proportions

From: Peter Zijlstra
Date: Tue May 29 2012 - 08:38:38 EST


On Tue, 2012-05-29 at 14:34 +0200, Jan Kara wrote:

> The only safe solution seems to be to create a variant of percpu counters
> that can be used from an interrupt. Or do you have other idea Peter?

> > [ 20.680186] [<ffffffff8325ac9b>] _raw_spin_lock+0x3b/0x70
> > [ 20.680186] [<ffffffff81993527>] ? __percpu_counter_sum+0x17/0xc0
> > [ 20.680186] [<ffffffff81993527>] __percpu_counter_sum+0x17/0xc0
> > [ 20.680186] [<ffffffff810ebf90>] ? init_timer_deferrable_key+0x20/0x20
> > [ 20.680186] [<ffffffff8195b5c2>] fprop_new_period+0x12/0x60
> > [ 20.680186] [<ffffffff811d929d>] writeout_period+0x3d/0xa0
> > [ 20.680186] [<ffffffff810ec0bf>] call_timer_fn+0x12f/0x260
> > [ 20.680186] [<ffffffff810ebf90>] ? init_timer_deferrable_key+0x20/0x20

Yeah, just make sure IRQs are disabled around doing that ;-)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/