Re: [PATCH V2] [staging] bcm: Replace the BCM_DEBUG_* andBCM_SHOW_* macros with functions

[Eric Dumazet]

On Tue, 2012-05-29 at 15:21 +0530, Devendra Naga wrote:
> This patch is made by following the improvements told by Joe Perches,
> replaced the BCM_DEBUG* and BCM_SHOW* macros into functions and added them
> in a file and added macros in the Debug.h file. This patch also improves the if
> check in bcm_show_debug_bitmap,
> 
> the check was
> 	if ((i == 1) || (i == 2) || (i == 4) || (i == 8));
> anyway its a check to find whether its a power of two, and replaces
> it like the following,
> 	if ((i != 0) && !(i & (i - 1)))

So why not using is_power_of_2() ?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/