Re: [PATCH] x86/irq: handle chained interrupts during IRQmigration

[Thomas Gleixner]

On Mon, 28 May 2012, Sundar Iyer wrote:

> chained interrupt handlers dont have an irqaction and hence
> are not handled during migrating interrupts when some cores
> go offline.
> 
> Handle this by introducing a new flag is_chained in the irq
> descriptor; fixup_irq() can then handle such interrupts and not
> skip them over.
> 
> Signed-off-by: Sundar Iyer <sundar.iyer@xxxxxxxxx>
> ---
>  arch/x86/kernel/irq.c   |    5 +++--
>  include/linux/irqdesc.h |    8 ++++++++
>  kernel/irq/chip.c       |    1 +
>  3 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> index 6c0802e..29f2f63 100644
> --- a/arch/x86/kernel/irq.c
> +++ b/arch/x86/kernel/irq.c
> @@ -249,8 +249,9 @@ void fixup_irqs(void)
>  
>  		data = irq_desc_get_irq_data(desc);
>  		affinity = data->affinity;
> -		if (!irq_has_action(irq) || irqd_is_per_cpu(data) ||
> -		    cpumask_subset(affinity, cpu_online_mask)) {
> +		if ((!irq_has_action(irq) && !irq_is_chained(irq)) ||
> +			irqd_is_per_cpu(data) ||
> +			cpumask_subset(affinity, cpu_online_mask)) {
>  			raw_spin_unlock(&desc->lock);
>  			continue;
>  		}
> diff --git a/include/linux/irqdesc.h b/include/linux/irqdesc.h
> index 2d921b3..0c7b474 100644
> --- a/include/linux/irqdesc.h
> +++ b/include/linux/irqdesc.h
> @@ -50,6 +50,7 @@ struct irq_desc {
>  	unsigned int		depth;		/* nested irq disables */
>  	unsigned int		wake_depth;	/* nested wake enables */
>  	unsigned int		irq_count;	/* For detecting broken IRQs */
> +	bool			is_chained;	/* for chained handlers */

No. We have flags and properties already. Please follow the existing
mechanisms instead of adding random fields to irq_desc.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/