Re: [PATCH] perf record: fix branch_stack type in perf_record_opts

[Anshuman Khandual]

On Saturday 26 May 2012 02:43 AM, Stephane Eranian wrote:

> 
> The attr.branch_sample_type field is defined as u64 by the API.
> As such, we need to ensure the variable holding the value of the
> branch stack filters is also u64 otherwise we may lose bits in
> the future.
> 
> Note also that the bogus definition of the field in
> perf_record_opts caused problems on big-endian PPC systems.
> Thanks to Anshuman Khandual for tracking the problem on PPC.
> 
> Signed-off-by: Stephane Eranian <eranian@xxxxxxxxxx>


Acked-by: Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx>

> ---
> 
> diff --git a/tools/perf/perf.h b/tools/perf/perf.h
> index 14f1034..f960ccb 100644
> --- a/tools/perf/perf.h
> +++ b/tools/perf/perf.h
> @@ -227,7 +227,7 @@ struct perf_record_opts {
>  	unsigned int freq;
>  	unsigned int mmap_pages;
>  	unsigned int user_freq;
> -	int	     branch_stack;
> +	u64          branch_stack;
>  	u64	     default_interval;
>  	u64	     user_interval;
>  };
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/