Re: [PATCH] [staging] bcm: Fix codingstyle problems

From: Joe Perches
Date: Mon May 28 2012 - 11:02:31 EST


On Mon, 2012-05-28 at 12:34 +0300, Dan Carpenter wrote:
> On Sun, May 27, 2012 at 09:37:39PM -0700, Joe Perches wrote:
> > On Mon, 2012-05-28 at 09:53 +0530, devendra.aaru wrote:
> > But read the TODO file. I'm not sure if
> > there's any value in working on bcm at all.
>
> The bcm driver is pretty crappy and can't maintain a connection for
> very long but we don't have a replacement, so it's worth fixing.

Well, the patch I suggested drops the size by 25%/100K
so it's probably worth something.

$ size drivers/staging/bcm/*.ko*
text data bss dec hex filename
260530 7248 53632 321410 4e782 drivers/staging/bcm/bcm_wimax.ko.new
338001 7192 84888 430081 69001 drivers/staging/bcm/bcm_wimax.ko.old


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/