Re: [PATCH] [staging] bcm: Fix codingstyle problems

[Joe Perches]

On Sun, 2012-05-27 at 22:30 -0400, Kevin McKinney wrote:
> Hi Devendra,
> 
> On Sun, May 27, 2012 at 4:54 PM, Devendra Naga <devendra.aaru@xxxxxxxxx> wrote:
> > Signed-off-by: Devendra Naga <devendra.aaru@xxxxxxxxx>
> > ---
> >  drivers/staging/bcm/Debug.h |    6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> I understand this is a simple change, but please add a descriptive
> change log to your patch for consistency.

Hello as well.

Devendra, sometimes the simpler change isn't the best change.
Consider converting some of these macros into functions.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/