Re: [PATCH 02/11] PCI: Try to allocate mem64 above 4G at first

From: Yinghai Lu
Date: Fri May 25 2012 - 14:39:27 EST


On Fri, May 25, 2012 at 10:53 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>> I don't really like the dependency on PCIBIOS_MAX_MEM_32 + 1ULL
>> overflowing to zero -- that means the reader has to know what the
>> value of PCIBIOS_MAX_MEM_32 is, and things would break in non-obvious
>> ways if we changed it.
>>

please check if attached one is more clear.

make max and bottom is only related to _MEM and not default one.

- if (!(res->flags & IORESOURCE_MEM_64))
- max = PCIBIOS_MAX_MEM_32;
+ if (res->flags & IORESOURCE_MEM) {
+ if (!(res->flags & IORESOURCE_MEM_64))
+ max = PCIBIOS_MAX_MEM_32;
+ else if (PCIBIOS_MAX_MEM_32 != -1)
+ bottom = (resource_size_t)(1ULL<<32);
+ }

will still not affect to other arches.


Thanks

Yinghai

Attachment: allocate_high_at_first.patch
Description: Binary data