Re: [PATCH] x86, realmode: 16-bit real-mode code support for relocstool

[Jarkko Sakkinen]

On Fri, 25 May 2012, Greg KH wrote:

> On Fri, May 25, 2012 at 08:44:43AM +0300, Jarkko Sakkinen wrote:
> > From: "H. Peter Anvin" <hpa@xxxxxxxxxxxxxxx>
> >
> > A new option is added to the relocs tool called '--realmode'.
> > This option causes the generation of 16-bit segment relocations
> > and 32-bit linear relocations for the real-mode code. When
> > the real-mode code is moved to the low-memory during kernel
> > initialization, these relocation entries can be used to
> > relocate the code properly.
> >
> > In the assembly code 16-bit segment relocations must be relative
> > to the 'real_mode_seg' absolute symbol. Linear relocations must be
> > relative to a symbol prefixed with 'pa_'.
> >
> > 16-bit segment relocation is used to load cs:ip in 16-bit code.
> > Linear relocations are used in the 32-bit code for relocatable
> > data references. They are declared in the linker script of the
> > real-mode code.
> >
> > The relocs tool is moved to arch/x86/tools/relocs.c, and added new
> > target archscripts that can be used to build scripts needed building
> > an architecture.  be compiled before building the arch/x86 tree.
> >
> > [ hpa: accelerating this because it detects invalid absolute
> >   relocations, a serious bug in binutils 2.22.52.0.x which currently
> >   produces bad kernels. ]
> >
> > [ jsakkine: pulled tools/include/tools/le_byteshift.h in order
> >   to make this patch compile in 3.3 ]
>
> Nope, your patch still doesn't apply, are you sure you sent me the
> updated one?  It fails with:
>
> patching file arch/x86/boot/compressed/Makefile
> Hunk #1 succeeded at 40 (offset 1 line).
> patching file arch/x86/boot/compressed/relocs.c
> Hunk #1 FAILED at 1.
> File arch/x86/boot/compressed/relocs.c is not empty after patch, as expected
> 1 out of 1 hunk FAILED -- rejects in file arch/x86/boot/compressed/relocs.c
>
> when applying it to the 3.3-stable queue.
>
> What did you generate it against?

Sent a new patch that is against 3.3.7.

> thanks,
>
> greg k-h

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/