Re: [PATCH 1/2] x86: add max_addr boot option

[Wen Congyang]

At 05/23/2012 10:25 PM, Bjorn Helgaas Wrote:
> On Tue, May 22, 2012 at 1:02 AM, Wen Congyang <wency@xxxxxxxxxxxxxx> wrote:
> 
>> +       if (start >= max_addr) {
>> +               printk(KERN_INFO "Ingoring memory: %016Lx - %016Lx\n",
>> +                      (unsigned long long)start,
>> +                      (unsigned long long)(start + size));
>> +               return;
>> +       }
>> +
>> +       if (max_addr - start < size) {
>> +               printk(KERN_INFO "Ingoring memory: %016Lx - %016Lx\n",
>> +                      (unsigned long long)max_addr,
>> +                      (unsigned long long)(start + size));
>> +               size = max_addr - start;
> 
> s/Ingoring/Ignoring/
> 
> Please use a format like "e820: ignoring [mem %#010Lx-%#010Lx]" so it
> matches other places where we print physical address ranges.  See
> https://lkml.org/lkml/2012/2/13/436

Hmm, no one reviews/acks patch. So I am not sure whether we need to do this.
So I think there is no need to use such format now.

Thanks
Wen Congyang
> 
> Bjorn
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/