Re: [PATCH v4 2/2] MFD: MAX77693: add IRQ handler

[Samuel Ortiz]

Hi Chanwoo,

On Mon, May 14, 2012 at 08:40:06PM +0900, Chanwoo Choi wrote:
> This patch supports IRQ handling for MAX77693.
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Signed-off-by: Myungjoo Ham <myungjoo.ham@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
This patch breaks the build in this way:

drivers/mfd/max77693.c: In function âmax77693_i2c_probeâ:
drivers/mfd/max77693.c:157:2: error: implicit declaration of function
âmax77693_irq_initâ [-Werror=implicit-function-declaration]
drivers/mfd/max77693.c: In function âmax77693_resumeâ:
drivers/mfd/max77693.c:215:2: error: implicit declaration of function
âmax77693_irq_resumeâ [-Werror=implicit-function-declaration]

drivers/mfd/max77693-irq.c: In function âmax77693_irq_lockâ:
drivers/mfd/max77693-irq.c:104:2: error: âstruct max77693_devâ has no member
named âirqlockâ
drivers/mfd/max77693-irq.c: In function âmax77693_irq_sync_unlockâ:
drivers/mfd/max77693-irq.c:119:11: error: âstruct max77693_devâ has no member
named âirq_masks_cacheâ
drivers/mfd/max77693-irq.c:119:42: error: âstruct max77693_devâ has no member
named âirq_masks_curâ
drivers/mfd/max77693-irq.c:122:13: error: âstruct max77693_devâ has no member
named âirq_masks_curâ
drivers/mfd/max77693-irq.c:125:24: error: âstruct max77693_devâ has no member
named âirqlockâ
drivers/mfd/max77693-irq.c: In function âmax77693_irq_maskâ:
drivers/mfd/max77693-irq.c:141:11: error: âstruct max77693_devâ has no member
named âirq_masks_curâ
drivers/mfd/max77693-irq.c:143:11: error: âstruct max77693_devâ has no member
named âirq_masks_curâ
drivers/mfd/max77693-irq.c: In function âmax77693_irq_unmaskâ:
drivers/mfd/max77693-irq.c:153:11: error: âstruct max77693_devâ has no member
named âirq_masks_curâ
drivers/mfd/max77693-irq.c:155:11: error: âstruct max77693_devâ has no member
named âirq_masks_curâ
drivers/mfd/max77693-irq.c: In function âmax77693_irq_threadâ:
drivers/mfd/max77693-irq.c:209:26: error: âstruct max77693_devâ has no member
named âirq_masks_curâ
drivers/mfd/max77693-irq.c:211:27: error: âstruct max77693_devâ has no member
named âirq_masks_curâ
drivers/mfd/max77693-irq.c:217:39: error: âstruct max77693_devâ has no member
named âirq_domainâ
drivers/mfd/max77693-irq.c: In function âmax77693_irq_initâ:
drivers/mfd/max77693-irq.c:260:2: error: âstruct max77693_devâ has no member
named âirqlockâ
drivers/mfd/max77693-irq.c:268:12: error: âstruct max77693_devâ has no member
named âirq_masks_curâ
drivers/mfd/max77693-irq.c:269:12: error: âstruct max77693_devâ has no member
named âirq_masks_cacheâ
drivers/mfd/max77693-irq.c:271:12: error: âstruct max77693_devâ has no member
named âirq_masks_curâ
drivers/mfd/max77693-irq.c:272:12: error: âstruct max77693_devâ has no member
named âirq_masks_cacheâ
drivers/mfd/max77693-irq.c:292:10: error: âstruct max77693_devâ has no member
named âirq_domainâ

I fixed it up for you with commit 78302a194c0ddf4438e50e3f9b327a6dce6bc8fc but
please make sure your code builds properly next time.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/