Re: [PATCH block/for-3.5/core] blkcg: tg_stats_alloc_lock is an irqlock

From: Jens Axboe
Date: Wed May 23 2012 - 06:17:26 EST


On 05/23/2012 11:54 AM, Sasha Levin wrote:
> On Thu, Apr 26, 2012 at 11:10 PM, Tejun Heo <tj@xxxxxxxxxx> wrote:
>> tg_stats_alloc_lock nests inside queue lock and should always be held
>> with irq disabled. throtl_pd_{init|exit}() were using non-irqsafe
>> spinlock ops which triggered inverse lock ordering via irq warning via
>> RCU freeing of blkg invoking throtl_pd_exit() w/o disabling IRQ.
>>
>> Update both functions to use irq safe operations.
>>
>> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
>> Reported-by: Sasha Levin <sasha.levin@xxxxxxxxxx>
>> LKML-Reference: <1335339396.16988.80.camel@lappy>
>> ---
>
> I think that this patch got lost somewhere and never got merged into
> the for-3.5 branch.

Seems it did, odd. Applied it now.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/