Re: [V2 PATCH 9/9] vhost: zerocopy: poll vq in zerocopy callback

From: Jason Wang
Date: Tue May 22 2012 - 06:13:31 EST


On 05/22/2012 12:12 AM, Shirley Ma wrote:
Then it could be too early for vhost to notify guest anywhere in
handle_tx for zerocopy. Then we might need to remove any notification in
handle_tx for zerocopy to vhost zerocopy callback instead.

Adding vhost_poll_queue in vhost zerocopy callback unconditionally would
consume unnecessary cpu.

We need to think about a better solution here.

A possible idea is only call vhost_poll_queue only when the packet of used_event were sent: if there's no out-of-order completion vhost could signal the guest; if there is, let the pending packets before used_event call vhost_poll_queue.
Thanks
Shirley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/