Re: [PATCH 1/7] [RFC] UBI: Export next_sqnum()
From: Richard Weinberger
Date: Mon May 21 2012 - 09:34:06 EST
On 16.05.2012 15:01, Artem Bityutskiy wrote:
I started looking at the code, and made some notes at the same time and
few minor changes - here is the diff which you can apply on top of your
patches.
diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
index 2399511..2f5c362 100644
--- a/drivers/mtd/ubi/build.c
+++ b/drivers/mtd/ubi/build.c
@@ -869,15 +869,22 @@ static int attach_by_fastmap(struct ubi_device *ubi)
fm_start = ubi_find_fastmap(ubi);
if (fm_start< 0)
+ /* TODO: instead, return 1 which means that fall-back to
+ * scanning is needed */
fm_start is the PEB number of the fastmap super block.
It will return 1 if the super block was found at PEB 1.
That's why it returns a negative values in case of an error.
+ /* TODO: Before checking version - check the CRC.
The CRC covers only the fastmap data, not the super block.
for (i = 0; i< nblocks; i++) {
+ /* TODO: you basically perform the scanning here - you should
+ * share the same code as we use in scan.c: use process_peb().
+ */
What exactly do you mean by that?
process_eb() will not help much because the fastmap data is written
"raw" to the flash. (Without any interaction from the WL sub-system)
I'll release v6 now and address all other issues in v7.
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/