Re: [PATCH v3 0/2] Move x86_cpu_to_apicid to the __read_mostlysection

From: Ingo Molnar
Date: Mon May 21 2012 - 08:33:02 EST



* Shai Fultheim (Shai@xxxxxxxxxxx) <Shai@xxxxxxxxxxx> wrote:

> Ingo,
>
> The reason for this, as you pointed out, is the 'cache line'
> size (4096 bytes). We see significant false sharing is we do
> not move this next to each other.

Which write-often variable caused the many cache flushes/fills?
cpu_to_apicid is read mostly.

I.e. it might make more sense to identify the frequenty
*modified* percpu variables, and move them to a separate
section. I *think* most percpu variables are read mostly, so it
would be more maintainable in the long run to figure out the
frequently modified ones, not the frequently not modified ones.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/