Re: [PATCH v3 1/2] x86: Define early read-mostly per-cpu macros

[Vlad Zolotarov]

On Monday, May 21, 2012 10:46:26 AM Ingo Molnar wrote:
> * Vlad Zolotarov <vlad@xxxxxxxxxxx> wrote:
> > Some read-mostly per-cpu data may need to be declared or defined early,
> > so it can be initialized and accessed before per_cpu areas are
> > allocated.
> > 
> > Only the data that resides in the per_cpu areas should be read-mostly,
> > as there is little benefit in optimizing cache lines on initialization.
> > 
> > Signed-off-by: Vlad Zolotarov <vlad@xxxxxxxxxxx>
> > Signed-off-by: Ido Yariv <ido@xxxxxxxxxx>
> > Signed-off-by: Shai Fultheim <shai@xxxxxxxxxxx>
> 
> That's not a valid signoff chain. If you send me a patch then
> you should be the last SOB - but as the author you should be the
> first SOB as well. I edited the two SOBs to be Acked-by's.

Thanks, Ingo. I understand. However the "history" of this patch is not as 
simple as u represent. ;) 

It was originally written by Ido and I just posted it (then I put my SOB at 
the end of SOB list). But after u noted that it didn't compile on !SMP i 
reworked it but yet Ido did at least half of the coding, so I put my SOB at 
the first place (as I was the last one writing the code) and then Ido's as he 
actually wrote the code in this patch as well and I do wanted to give him a 
credit.

Do u still think changing his (Ido's) SOB to Acked-by was the right thing to 
do?

Thanks,
vlad

> 
> Thanks,
> 
> 	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/