Re: [PATCH 2/3] regulator: MAX77686: Add Maxim 77686 regulator driver

[Mark Brown]

On Mon, May 21, 2012 at 04:33:15PM +0900, jonghwa3.lee@xxxxxxxxxxx wrote:
> On 2012ë 05ì 21ì 00:56, Mark Brown wrote:
> > On Fri, May 18, 2012 at 06:32:18PM +0900, Jonghwa Lee wrote:

> >> +	}, {
> >> +		.name	= "EN32KHz PMIC",
> >> +		.id	= MAX77686_P32KH,
> >> +		.ops	= &max77686_fixedvolt_ops,
> >> +		.type	= REGULATOR_VOLTAGE,
> >> +		.owner	= THIS_MODULE,
> >> +	},

> > These should be managed via the clock API now we have one.

> I already updated all your comments except only this one. Could you
> explain more details?

We now have a generic clock framework in drivers/clk so we should be
using that to provide drivers for clocks rather than putting them into
the regulator API which was always a bodge.

Attachment: signature.asc
Description: Digital signature