Re: [PATCH v2 4/5] perf record: add meta-data support for pipe-mode

From: Arnaldo Carvalho de Melo
Date: Fri May 18 2012 - 13:19:25 EST


Em Fri, May 18, 2012 at 10:50:45AM -0600, David Ahern escreveu:
> On 5/16/12 1:41 AM, Stephane Eranian wrote:
> >On Wed, May 16, 2012 at 5:34 AM, David Ahern<dsahern@xxxxxxxxx> wrote:
> >>I love the feature and it works nicely, but there has been push back on
> >>adding more synthesized events. Also the size of the patch is a bit much to
> >>take in. If there is no objection to the synthesized can you break the patch
> >>up -- e.g., introduce the events in one, synthesis and processing functions
> >>in another, plug into the commands, ...
> >>
> >Without new synthesized events, you cannot make this work. This is by
> >construction
> >of the pipe mode. Meta-data has be be injected in the stream and
> >therefore it needs
> >PERF_RECORD_* types.
>
> Understood. I don't object to synthesized events.
>
> Arnaldo: preferences?

PeterZ was the one objecting to adding more userspace only events,
Peter?

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/