Re: lockdep false positive in double_lock_balance()?

From: Steven Rostedt
Date: Fri May 18 2012 - 10:43:04 EST


On Thu, 2012-05-17 at 21:19 +0200, Peter Zijlstra wrote:

> Something like this should fix it I think..
>
>
> ---
> kernel/sched/rt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index c5565c3..b649108 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -1556,7 +1556,7 @@ static struct rq *find_lock_lowest_rq(struct task_struct *task, struct rq *rq)
> task_running(rq, task) ||
> !task->on_rq)) {
>
> - raw_spin_unlock(&lowest_rq->lock);
> + double_unlock_balance(rq, lowest_rq);

Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

-- Steve

> lowest_rq = NULL;
> break;
> }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/