Re: [tip:core/debug] kdump: Execute kmsg_dump(KMSG_DUMP_PANIC)after smp_send_stop()

[Peter Zijlstra]

On Fri, 2012-05-18 at 03:49 -0700, tip-bot for Seiji Aguchi wrote:

> kdump: Execute kmsg_dump(KMSG_DUMP_PANIC) after smp_send_stop()
> 
> This patch moves kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop(),
> to serialize the crash-logging process via smp_send_stop() and to
> thus retrieve a more stable crash image of all CPUs stopped.

I don't want to be a spoil sport or anything, but this patch doesn't
move anything, it just removes..

> ---
>  kernel/panic.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/panic.c b/kernel/panic.c
> index b6215b7..d4f0b61 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -108,8 +108,6 @@ void panic(const char *fmt, ...)
>  	 */
>  	crash_kexec(NULL);
>  
> -	kmsg_dump(KMSG_DUMP_PANIC);
> -
>  	/*
>  	 * Note smp_send_stop is the usual smp shutdown function, which
>  	 * unfortunately means it may not be hardened to work in a panic


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/