Re: [PATCH v2 3/3] x86: Support local_flush_tlb_kernel_range

From: Minchan Kim
Date: Fri May 18 2012 - 04:36:04 EST


Hi Peter,

On 05/17/2012 11:51 PM, Peter Zijlstra wrote:

> On Thu, 2012-05-17 at 17:11 +0900, Minchan Kim wrote:
>>> +++ b/arch/x86/include/asm/tlbflush.h
>>> @@ -172,4 +172,16 @@ static inline void flush_tlb_kernel_range(unsigned long start,
>>> flush_tlb_all();
>>> }
>>>
>>> +static inline void local_flush_tlb_kernel_range(unsigned long start,
>>> + unsigned long end)
>>> +{
>>> + if (cpu_has_invlpg) {
>>> + while (start < end) {
>>> + __flush_tlb_single(start);
>>> + start += PAGE_SIZE;
>>> + }
>>> + } else
>>> + local_flush_tlb();
>>> +}
>
>
> It would be much better if you wait for Alex Shi's patch to mature.
> doing the invlpg thing for ranges is not an unconditional win.


Thanks for the information. I will watch that patchset.
Thanks.

--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/