Re: [PATCH v6 04/12] x86/smpboot.c: Don't offline CPU0 if any irqcan not be migrated out of it and remove CPU0 check in smp_callin()

From: Suresh Siddha
Date: Thu May 17 2012 - 18:49:03 EST


On Mon, 2012-05-14 at 14:17 +0200, Ingo Molnar wrote:
> * Tony Luck <tony.luck@xxxxxxxxx> wrote:
>
> > Biggest code impact of that is the extra code to bring cpu0
> > back online using NMI instead of INIT. We can't use INIT
> > because if cpu0 gets one, it just resets the whole machine :-(
> > But obviously we'd like to avoid special cases where there is
> > a sane way to do so.
>
> Could we just standardize on NMI bringup during regular bootup?

May be we can use the NMI or even better monitor/mwait based bringup to
re-online an AP that is currently offline in play_dead(), specifically
if we haven't lost that AP processor state because of suspend/resume
event etc.

This can speed-up online if we want to use light weight online/offline
of the AP's for saving power on mobile platforms.

thanks,
suresh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/